Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(config): rename _config to _config.example #142

Merged
merged 2 commits into from
Jan 17, 2017
Merged

refactor(config): rename _config to _config.example #142

merged 2 commits into from
Jan 17, 2017

Conversation

iblh
Copy link
Owner

@iblh iblh commented Jan 17, 2017 •
edited by neoFelhz
Loading

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@iblh iblh requested a review from pidupuis January 17, 2017 08:11
@iblh iblh changed the base branch from master to canary January 17, 2017 08:11
@iblh iblh requested a review from neoFelhz January 17, 2017 08:25
@pidupuis
Copy link
Collaborator

That's a good idea!

It would be more idiomatic to call it _config.template.yml though.

With this PR I think you could remove the _config.viosey.yml line from the .gitignore.

@iblh
Copy link
Owner Author

iblh commented Jan 17, 2017

@pidupuis you're right.

@iblh iblh merged commit 1815c59 into canary Jan 17, 2017
@iblh iblh mentioned this pull request Jan 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neoFelhz neoFelhz neoFelhz approved these changes

@pidupuis pidupuis Awaiting requested review from pidupuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iblh @pidupuis @neoFelhz